-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dump walkers periodically for post-processing #4940
Open
Paul-St-Young
wants to merge
6
commits into
QMCPACK:develop
Choose a base branch
from
Paul-St-Young:dump_walkers
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a1b5edc
update instead of rewrite config.h5
Paul-St-Young 106569e
more thorough cleanup of previous checkpoint
Paul-St-Young 3c74d97
implement identify_block
Paul-St-Young bd6bd54
rename walker_weights and walker_partition
Paul-St-Young 42b10ed
use dump with identify_block
Paul-St-Young e8594eb
comment on identify_block
Paul-St-Young File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,9 +50,14 @@ class HDFWalkerOutput | |
~HDFWalkerOutput(); | ||
|
||
/** dump configurations | ||
* @param w walkers | ||
* Write walkers into hdf file. | ||
* The "walkers" dataset typically resides at "state_0/walkers", which | ||
* contains no information about when it was written (at which block). | ||
* The identify_block flag appends the block index to uniquely identify | ||
* each walker dump, e.g., "state_0/walkers10" is from block 10. | ||
* | ||
*/ | ||
bool dump(const WalkerConfigurations& w, int block); | ||
bool dump(const WalkerConfigurations& w, int block, const bool identify_block=false); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please document what identify_block=true do. |
||
// bool dump(ForwardWalkingHistoryObject& FWO); | ||
|
||
private: | ||
|
@@ -62,7 +67,7 @@ class HDFWalkerOutput | |
std::array<BufferType, 2> RemoteData; | ||
std::array<std::vector<QMCTraits::FullPrecRealType>, 2> RemoteDataW; | ||
int block; | ||
void write_configuration(const WalkerConfigurations& W, hdf_archive& hout, int block); | ||
void write_configuration(const WalkerConfigurations& W, hdf_archive& hout, int block, const bool identify_block); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please document what identify_block=true do. |
||
}; | ||
|
||
} // namespace qmcplusplus | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you mentioned the data set name used for recording instead of checkpointing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dataset name for recording is
walkers{block_idx}
, whereas the name for checkpoint is simplywalkers
.