Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Batched converter #5231

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

anbenali
Copy link
Contributor

Please review the developer documentation
on the wiki of this project that contains help and requirements.

Proposed changes

Describe what this PR changes and why. If it closes an issue, link to it here
This PR introduces 2 changes:

  1. Support for gpu4pyscf in the PyscfToQmcpack.py code to handle Cupy changes in mf.mocoeff.
  2. convert4qmc generates by default batch code instead of legacy. to generate old legacy input, --legacy is needed.

What type(s) of changes does this code introduce?

Delete the items that do not apply

  • New feature

  • Documentation or build script changes

  • Other (please describe):

Does this introduce a breaking change?

  • Yes

What systems has this change been tested on?

-Endymion (personal Server - AMD ROME 7503 - NVIDIA Geforce RTX 4070 Titanium Super)

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • Yes. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@anbenali
Copy link
Contributor Author

tests need to be updated to match. unfortunately, if b3lyp is called like in most examples, DFT gives different values as the definition of B3LYP has changed in the past years and new QMC runs are needed.

Help to create tests is required @prckent @Hyeondeok-Shin

@prckent
Copy link
Contributor

prckent commented Nov 19, 2024

Suggesting a fast route to get this merged:

  1. I think you only need to update the gold files to get the converter tests passing -- QMC runs are not done. We can run spot checks once the tests are passing.
  2. Some testing of --legacy is needed. Probably easiest to duplicate the tests and add a set of gold files. Could do for just one test if the code paths are close enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants