[Nexus] Remove deprecated Matplotlib keyword warn from plotting.py
#5622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module `plotting.py` contained a series of `try... except` statements to test for matplotlib, however in the innermost nested `try... except` the command `matplotlib.use()` was invoked with a keyword `warn=False` that has been deprecated since at least the release of matplotlib 3.3, and has been defaulted to `False` since matplotlib 3.0. Given that matplotlib <3.0 is for Python 2 mostly, and since Nexus does not support Python 2 anymore, this should be removed. Previously, this was throwing an exception that was not caught because of the `try... except` statement it was contained in that caught all exceptions, in this case a `TypeError`, even though it should only be catching the correct exception of `ValueError`.
Same issue as in `plotting.py` See QMCPACK#5622 for details
prckent
approved these changes
Sep 25, 2025
|
Test this please |
|
Going ahead with merge since this is a minor local change and easy to revert in the unlikely event it is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The module
plotting.pycontained a series oftry... exceptstatements to test for matplotlib, however in the innermost nestedtry... exceptthe commandmatplotlib.use()was invoked with a keywordwarn=Falsethat has been deprecated since at least the release of matplotlib 3.3, and has been defaulted toFalsesince matplotlib 3.0. Given that matplotlib <3.0 is for Python 2 mostly, and since Nexus does not support Python 2 anymore, this should be removed.Previously, this was throwing an exception that was not caught because of the
try... exceptstatement it was contained in that caught all exceptions, in this case aTypeError, even though it should only be catching the correct exception ofValueError.What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Perlmutter with Python 3.9.18 using Matplotlib 3.8.2, and Python 3.13.2 and Matplotlib 3.10.1
Checklist