Replace QB items.lua and weapons.lua with Ox #451
+775
−546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scullyy
added a commit
to Scullyy/qbx_policejob
that referenced
this pull request
Apr 20, 2024
Scullyy
added a commit
to Scullyy/qbx_policejob
that referenced
this pull request
Apr 20, 2024
Convert weapons.lua requirement to ox
Scullyy
added a commit
to Scullyy/qbx_policejob
that referenced
this pull request
Apr 20, 2024
Convert weapons.lua requirement to ox
Scullyy
added a commit
to Scullyy/qbx_medical
that referenced
this pull request
Apr 20, 2024
- Uses Qbox-project/qbx_core#451 - Added damage reasons since this handles damage
2 tasks
Manason
requested changes
Apr 20, 2024
TonybynMp4
approved these changes
Apr 20, 2024
Scullyy
changed the title
|
The items.lua will need to replace the one inside ox_inventory with the recipe. If not using the oldItems method this may need it's own bridge inside ox_inventory. |
|
I am not sure about this, I would rather not have an items.lua anymore in the future as they all get picked up by ox_inventory and placed in the data/items.lua anyway, otherwise they don't work |
|
only issue that i see is when ox inventory try to convert the item lua in shared what happens then |
This was referenced May 19, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replaces the QBCore items.lua and weapons.lua with the ox one, I also had to add a WeaponHashes table for reverse hashing since ox uses strings. I have open PR's on other resources to be compatible with this also.
Checklist