Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(character): Use tutorial natives instead of manual bucket setting #480

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

solareon
Copy link
Member

@solareon solareon commented Jun 5, 2024

Description

Routing buckets may overlap. The natives do a better job of hiding the characters. This is similar to #473 but moves the tutorial end to the QBCore:Client:OnPlayerLoaded event to end the tutorial session with the appropriate native.

Additionally it only calls the tutorial session start one time if somehow the choosecharacter() function got called twice without being disabled cause who knows if that works right.

NOTE: I have NOT tested this. Do not merge without extensive testing in a multiplayer environment.

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants