Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lib): return oldValue with handler #482

Closed
wants to merge 1 commit into from
Closed

feat(lib): return oldValue with handler #482

wants to merge 1 commit into from

Conversation

solareon
Copy link
Member

@solareon solareon commented Jun 6, 2024

Description

Improves functionality of the entityStateHandler by returning the previous statebag value to allow for easier comparison.

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

@solareon
feat(lib): return oldValue with handler
8128932 
Improves functionality of the entityStateHandler by returning the previous statebag value to allow for easier comparison.
Manason
Manason requested changes Jun 10, 2024
View reviewed changes
Copy link
Member

@Manason Manason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can get the current value by checking the state bag. Will approve if someone tests and confirms this is not the case.

@solareon solareon closed this Jul 25, 2024
@solareon solareon deleted the feat-statebags branch July 25, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manason Manason Manason requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@solareon @Manason