fix(server/functions): ban checking edge case #519
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There seems to be a weird edge case in ban checking which I believe is the issue in #463.
Currently we pull whichever license the player has (license2 first then license) and then check it against the bans table to see if the individual is banned. If you have an admin menu which bans by license but you have a license2, the check will give a false positive and allow the player through because it did not check by license. This fixes that by first checking by license2 and then by license to make sure we catch both cases.
Feel free to comment or start a discussion below. Idk if there's a better way we'd like to do this.
Checklist