fix(server/functions): ban checking edge case

[mafewtm]

Description

There seems to be a weird edge case in ban checking which I believe is the issue in #463.

Currently we pull whichever license the player has (license2 first then license) and then check it against the bans table to see if the individual is banned. If you have an admin menu which bans by license but you have a license2, the check will give a false positive and allow the player through because it did not check by license. This fixes that by first checking by license2 and then by license to make sure we catch both cases.

Feel free to comment or start a discussion below. Idk if there's a better way we'd like to do this.

Checklist

• I have personally loaded this code into an updated Qbox project and checked all of its functionality.
• My pull request fits the contribution guidelines & code conventions.

[mafewtm]

Now that I think about it, editing the fetchBan SQL is probably a better alternative than this. I'll do that tomorrow if y'all agree.

[solareon]

Now that I think about it, editing the fetchBan SQL is probably a better alternative than this. I'll do that tomorrow if y'all agree.

Yeah to use the same lookup as the fetch characters.