-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorten and use kebab-case for qiskit-ibm-runtime URLs #2593
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Please don't merge until a) ibm-transpiler is 100% landed in prod, and b) you have the redirect code set up in closed source and we've reviewed it |
Thank you both for the review!
Yes! That was my plan 👍 In the last commit (0314cff), I changed the I think the change is safe, and I tested it by regenerating qiskit (latest, and one historical version), qiskit-addon-obp (currently using the new URLs), and runtime (latest, and one historical version). None of them showed any change in the docs. Once all versions use the new URLs, we can change it to update links from |
I updated the script to special case URLs with a version (e.g. v1 or v2) in 1cbca72. To help with the review of that change, I regenerated every version in a different commit again. That way, we can check that the change didn't affect any other link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Bummer the diff treats some files as being deleted. The redirect code looks good too, so this can be merged when you're ready.
This PR is a continuation of #2177 for all the versions of qiskit-ibm-runtime.
Once this PR is reviewed and accepted, I'll also set the redirects in closed source.