Clarify CNOT control, target, and basis ordering - #5625
Open
Henry Zou (henryzou50) wants to merge 1 commit into
Open
Clarify CNOT control, target, and basis ordering#5625Henry Zou (henryzou50) wants to merge 1 commit into
Henry Zou (henryzou50) wants to merge 1 commit into
Conversation
Distinguish gate argument order from Qiskit's ket ordering and replace the ambiguous equation with the explicit CNOT transformation. Preserve the correct matrix, code, and notebook outputs. Fixes #5622
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
|
One or more of the following people are relevant to this code: |
6 tasks
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies the CNOT explanation in “Get started with Qiskit in the classroom” to distinguish control/target argument order from Qiskit’s ket ordering.
The existing matrix is correct and remains unchanged, along with code and notebook outputs.
Validation: Verified the matrix and all four basis-state mappings with Qiskit. Markdown, spelling, and internal-link checks passed.
Fixes #5622.