Order labels into categories #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankharkins
commented
Jul 3, 2024
Eric-Arellano
approved these changes
Jul 3, 2024
Co-authored-by: Eric Arellano <[email protected]>
Merged
frankharkins
added a commit
that referenced
this pull request
Jul 4, 2024
### Summary This PR updates the labels to the new list for the new ecosystem page. There are a few changes here but it's not easy to split them into PRs as many rely on eachother. To make reviewing easier, you can instead view each commit. 1. cdad7f6 updates `labels.json` with the new list of labels. 2. 8a0249a uses a short script to automatically remove and update labels. This commit also adds the `ibm_maintained` attribute to the repository model, which will be required for the new page. <details><summary>Show script</summary> ```python from ecosystem.daos import DAO REMOVED_LABELS = [ "Advocate mentorship project", "Circuit", "IBM maintained", "Julia", "Jupyter notebook", "Partner", "Education", "Hardware", "OpenQASM", "Productivity", "Prototype", "Quantum information", "Rust", "Visualization", ] dao = DAO("ecosystem/resources/") for repo in dao.get_all(): # Pull IBM maintenance status into attribute if "IBM maintained" in repo.labels: repo.ibm_maintained = True # Update labels if "Circuit" in repo.labels: repo.labels.append("Circuit building tool") repo.labels = [l for l in repo.labels if l not in REMOVED_LABELS] repo.labels.sort() # Turn group attribute into label if repo.group == "transpiler_plugin": repo.labels.append("Transpiler plugin") if repo.group == "applications": repo.labels.append("Application package") if repo.group == "provider": repo.labels.append("Compute provider") dao.write(repo) ``` </details> The `group` attribute can be ignored by the new ecosystem page, so it will remain until the current page it taken down. 3. 26e1594 manually reviews each member again to make sure labels are still relevant. 4. 84061e3 adds some logic to have the `ibm_maintained` attribute appear as a label on the current webpage. Like #742, this makes the current website generation script a bit more brittle. This is ok as it's a temporary trade-off; the current page will not be online much longer. 5. 71e13b7 updates the issue template with the new labels and `ibm_maintained` attribute. It also updates the parser to handle the new attribute. See https://github.com/frankharkins/ecosystem/pull/95/files for an example of the parser working correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR orders labels into categories, which is needed for the new ecosystem page. It does not remove or edit any labels, that's work for a future PR.