Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for specialized measurement with dynamic circuits #13652

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mtreinish
Copy link
Member

Summary

In the target model we have had support for a long time for creating specialized measurements by subclassing the Measure class and then adding that subclass to your target. However, this functionality was never tested explicitly. This commit closes that coverage gap by adding a dedicated test for this full path transpilation with the preset pass managers ensuring the operations pass through the transpiler and are preserved as measurements.

Details and comments

In the target model we have had support for a long time for creating
specialized measurements by subclassing the Measure class and then
adding that subclass to your target. However, this functionality was
never tested explicitly. This commit closes that coverage gap by adding
a dedicated test for this full path transpilation with the preset pass
managers ensuring the operations pass through the transpiler and are
preserved as measurements.
@mtreinish mtreinish added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Jan 10, 2025
@mtreinish mtreinish requested a review from a team as a code owner January 10, 2025 19:38
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12716121941

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 15 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.006%) to 88.913%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 93.18%
crates/qasm2/src/lex.rs 2 93.23%
crates/qasm2/src/parse.rs 12 96.69%
Totals Coverage Status
Change from base Build 12710188694: -0.006%
Covered Lines: 79421
Relevant Lines: 89324

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants