Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Fix equality and pickling of DAGCircuit with stretches #14114

Merged
merged 2 commits into from
Mar 28, 2025
Merged

[Backport] Fix equality and pickling of DAGCircuit with stretches #14114

merged 2 commits into from
Mar 28, 2025

Conversation

kevinhartman
Copy link
Contributor

Backport of #14000

Summary

During testing, I've found two bugs with DAGCircuit's handling of stretches:

  1. Stretch capture order should not matter in circuit equality #13998
  2. DAGCircuit does not properly pickle stretches #13999

They are fixed here.

@kevinhartman kevinhartman requested a review from a team as a code owner March 27, 2025 21:10
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@kevinhartman kevinhartman self-assigned this Mar 27, 2025
@kevinhartman kevinhartman added this to the 2.0.0 milestone Mar 27, 2025
@kevinhartman kevinhartman added the Changelog: None Do not include in changelog label Mar 27, 2025
@kevinhartman kevinhartman requested a review from mtreinish March 27, 2025 21:11
mtreinish
mtreinish reviewed Mar 28, 2025
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this LGTM, thanks for doing this. I think code-wise it's ready to merge. I just had a tiny nit/inline suggestion for a code comment about the private getters.

@mtreinish mtreinish self-assigned this Mar 28, 2025
@mtreinish mtreinish enabled auto-merge March 28, 2025 18:29
@mtreinish mtreinish added this pull request to the merge queue Mar 28, 2025
Merged via the queue into Qiskit:stable/2.0 with commit c534019 Mar 28, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees

@kevinhartman kevinhartman

@mtreinish mtreinish

Labels
Changelog: None Do not include in changelog
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinhartman @qiskit-bot @mtreinish