Feature/25 adminpage #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwookim
reviewed
Dec 19, 2024
Comment on lines
+14
to
+22
| if (!userInfo) { | ||
| return <Navigate to='/login' replace />; | ||
| } else if (!allowedRoles.includes(userInfo.role)) { | ||
| } | ||
|
|
||
| // 역할이 허용되지 않은 경우 | ||
| if (!allowedRoles.includes(userInfo.role)) { | ||
| return <Navigate to='/' replace />; | ||
| } |
There was a problem hiding this comment.
위의 else if는 실수겠죠? 😄
404페이지가 있다면 거기로 넘겨버려도 괜찮을지도 모르겠네요.
덤으로 파일 이름도 AdminRoute가 아닌 ProtectedRoute로 바꾸면 조금 더 혼란이 적어질 것 같아요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
#25
📝작업 내용
스크린샷 (선택)
관리자 로그인
유저 로그인
관리자 페이지
💬리뷰 요구사항(선택)