Feature/29 admin user management #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlcks0601
requested review from
HANTAEDONG,
HongbiKo,
YouD0313,
hwookim and
peppertown
hwookim
reviewed
Dec 19, 2024
| export const fetchAdminData = async () => { | ||
| try { | ||
| const response = await httpClient.get<AdminData[]>('/api/admin'); | ||
| console.log('응답 데이터:', response.data); |
There was a problem hiding this comment.
사실 console.log는 일반적으로는 지양되어야하는 코드입니다.
되도록이면 네트워크 탭의 정보를 통해 확인하면 더 좋을 내용인 것 같네요 👀
| @@ -0,0 +1,7 @@ | |||
| export interface AdminData { | |||
There was a problem hiding this comment.
AdminData라는 이름은 조금 헷갈릴지도 모르겠어요.
적어도 user가 네이밍 속에 들어가야 좀 더 명확해지지 않을까요? 👀
Comment on lines
+4
to
+10
| interface UserCardProps { | ||
| nickname: string; | ||
| email: string; | ||
| createdAt: string; | ||
| icon: string | null; | ||
| isOpen: boolean; | ||
| } |
There was a problem hiding this comment.
선언된 인터페이스 AdminData과 내용이 거의 유사한데,
이를 활용할 수는 없을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
#29
📝작업 내용
어드민 페이지 구현, 기능 구현 (관리자 페이지) 6b19b42
코드 리팩토링 eb28036
스크린샷 (선택)
💬리뷰 요구사항(선택)