Feat/#4

src/main/java/org/example/qpin/domain/carphoto/controller/CarPhotoController.java

@@ -23,12 +23,12 @@ public void saveCarPhoto(@RequestBody CarPhotoRequestDto carPhotoRequestDto) {
         carPhotoService.saveCarPhoto(carPhotoRequestDto);
     }
 
-    @GetMapping("/selectList")
+    @GetMapping
     public List<CarPhotoResponseDto> getCarPhotoList(@RequestParam Long memberId) {
         return carPhotoService.getCarPhotoList(memberId);
     }
 
-    @DeleteMapping("/remove/{photoId}")
+    @DeleteMapping("/{photoId}")
     public void deleteCarPhoto(@PathVariable Long photoId) {
         carPhotoService.deleteCarPhoto(photoId);
     }

src/main/java/org/example/qpin/domain/carphoto/service/CarPhotoServiceImpl.java

@@ -6,6 +6,8 @@
 import org.example.qpin.global.common.repository.CarPhotoRepository;
 import org.example.qpin.domain.member.entity.Member;
 import org.example.qpin.global.common.repository.MemberRepository;
+import org.example.qpin.global.exception.BadRequestException;
+import org.example.qpin.global.exception.ExceptionCode;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Service;
 
@@ -18,16 +20,26 @@ public class CarPhotoServiceImpl implements CarPhotoService {
     private final CarPhotoRepository carPhotoRepository;
     private final MemberRepository memberRepository;
 
+    public Member findMemberById(Long memberId) {
+        return memberRepository.findById(memberId).orElseThrow(() -> new BadRequestException(ExceptionCode.NOT_FOUND_MEMBER_ID));
+    }
+
+    public CarPhoto findCarPhotoById(Long photoId) {
+        return carPhotoRepository.findById(photoId).orElseThrow(() -> new BadRequestException(ExceptionCode.NOT_FOUND_PHOTO));
+    }
+
+    // 의존성 주입
     @Autowired
     public CarPhotoServiceImpl(CarPhotoRepository carPhotoRepository, MemberRepository memberRepository) {
         this.carPhotoRepository = carPhotoRepository;
         this.memberRepository = memberRepository;
     }
 
+    // 사진 저장
     @Override
     public void saveCarPhoto(CarPhotoRequestDto carPhotoRequestDto) {
-        Member member = memberRepository.findById(carPhotoRequestDto.getUserId())
-                .orElseThrow(() -> new RuntimeException("Member Not Found for id"));
+        Member member = findMemberById(carPhotoRequestDto.getUserId());
+
         CarPhoto carPhoto = CarPhoto.builder()
                 .carPhotoUrl(carPhotoRequestDto.getCarPhotoUrl())
                 .parkingArea(carPhotoRequestDto.getParkingArea())
@@ -37,8 +49,10 @@ public void saveCarPhoto(CarPhotoRequestDto carPhotoRequestDto) {
         carPhotoRepository.save(carPhoto);
     }
 
+    // 모든 사진 조회
     @Override
     public List<CarPhotoResponseDto> getCarPhotoList(Long memberId) {
+        findMemberById(memberId);
         List<CarPhoto> carPhotos = carPhotoRepository.findByMember_MemberId(memberId);
 
         return carPhotos.stream()
@@ -50,8 +64,11 @@ public List<CarPhotoResponseDto> getCarPhotoList(Long memberId) {
                 .collect(Collectors.toList());
     }
 
+    // 사진 삭제
     @Override
     public void deleteCarPhoto(Long photoId) {
+        findCarPhotoById(photoId);
+
         carPhotoRepository.deleteById(photoId);
     }
-}
+}

src/main/java/org/example/qpin/global/exception/ExceptionCode.java

@@ -25,6 +25,7 @@ public enum ExceptionCode {
     INVALID_IMAGE_PATH(5101, "이미지를 저장할 경로가 올바르지 않습니다."),
     FAIL_IMAGE_NAME_HASH(5102, "이미지 이름을 해싱하는 데 실패했습니다."),
     INVALID_IMAGE(5103, "올바르지 않은 이미지 파일입니다."),
+    NOT_FOUND_PHOTO(5104, "사진을 찾을 수 없습니다."),
 
     // 주차 에러
     NOT_FOUND_PARKING(6001, "요청한 주차ID와 멤버ID에 해당하는 정보가 존재하지 않습니다."),