Skip to content

Fix guard in ilist.FlattenAdd to give up on BottomType inputs. #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Roger-luo merged 2 commits into from
Dec 9, 2025
Merged

Fix guard in ilist.FlattenAdd to give up on BottomType inputs. #590

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aae487a
fixing bug in initial rewrite guard
weinbe58 Nov 28, 2025
96c5500
movign assert and giving more clear message
weinbe58 Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/kirin/dialects/ilist/rewrite/flatten_add.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,16 @@ class FlattenAdd(RewriteRule):
def rewrite_Statement(self, node: ir.Statement) -> RewriteResult:
if not (
isinstance(node, py.binop.Add)
and node.lhs.type.is_subseteq(ilist.IListType)
and node.rhs.type.is_subseteq(ilist.IListType)
and (lhs_type := node.lhs.type).is_subseteq(ilist.IListType)
and (rhs_type := node.rhs.type).is_subseteq(ilist.IListType)
and not lhs_type.is_structurally_equal(types.Bottom)
and not rhs_type.is_structurally_equal(types.Bottom)
):
return RewriteResult()

assert isinstance(rhs_type, types.Generic), "Expecting generic type for IList"
assert isinstance(lhs_type, types.Generic), "Expecting generic type for IList"

# check if we are adding two ilist.New objects
new_data = ()

Expand Down Expand Up @@ -46,9 +51,6 @@ def rewrite_Statement(self, node: ir.Statement) -> RewriteResult:
):
return RewriteResult()

assert isinstance(rhs_type := rhs.type, types.Generic), "Impossible"
assert isinstance(lhs_type := lhs.type, types.Generic), "Impossible"

lhs_elem_type = lhs_type.vars[0]
rhs_elem_type = rhs_type.vars[0]

Expand Down