Skip to content

fix: Emit warnings when files cannot be read instead of failing silently #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Desperado merged 1 commit into from
Mar 26, 2026
Merged

fix: Emit warnings when files cannot be read instead of failing silently #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions supply_chain_scanner/test_supply_chain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import re
import site
import sys
import warnings
import zlib
from pathlib import Path

Expand Down Expand Up @@ -333,7 +334,8 @@ def test_no_suspicious_pth_files(self):
for pth_file in pth_files:
try:
content = pth_file.read_text(errors="replace")
except (OSError, PermissionError):
except (OSError, PermissionError) as exc:
warnings.warn(f"Could not read {pth_file}: {exc}", stacklevel=1)
continue

issues = []
Expand Down Expand Up @@ -387,7 +389,8 @@ def test_pth_files_are_path_only(self):
for pth_file in pth_files:
try:
content = pth_file.read_text(errors="replace")
except (OSError, PermissionError):
except (OSError, PermissionError) as exc:
warnings.warn(f"Could not read {pth_file}: {exc}", stacklevel=1)
continue

for line_num, line in enumerate(content.splitlines(), 1):
Expand Down Expand Up @@ -428,7 +431,8 @@ def test_no_encoded_exfiltration_payloads(self):

try:
content = py_file.read_text(errors="replace")
except (OSError, PermissionError):
except (OSError, PermissionError) as exc:
warnings.warn(f"Could not read {py_file}: {exc}", stacklevel=1)
continue

# Scan for encoded strings (base64, hex)
Expand Down Expand Up @@ -464,7 +468,8 @@ def test_no_string_concat_obfuscation(self):

try:
content = py_file.read_text(errors="replace")
except (OSError, PermissionError):
except (OSError, PermissionError) as exc:
warnings.warn(f"Could not read {py_file}: {exc}", stacklevel=1)
continue

for pattern in OBFUSCATION_PATTERNS:
Expand Down Expand Up @@ -562,7 +567,8 @@ def test_no_suspicious_egg_info_scripts(self):
for pattern in SUSPICIOUS_PATTERNS:
if pattern.search(content):
suspicious.append(f"{egg_info.name}/{script.name}: {pattern.pattern}")
except (OSError, PermissionError):
except (OSError, PermissionError) as exc:
warnings.warn(f"Could not read {script}: {exc}", stacklevel=1)
continue

assert not suspicious, f"Packages with suspicious install scripts: {suspicious}"
Expand All @@ -585,7 +591,8 @@ def test_no_setup_py_with_network_calls(self):
for pattern in network_patterns:
if pattern.search(content):
suspicious.append(f"{setup_py.parent.name}/setup.py: {pattern.pattern}")
except (OSError, PermissionError):
except (OSError, PermissionError) as exc:
warnings.warn(f"Could not read {setup_py}: {exc}", stacklevel=1)
continue

assert not suspicious, f"Packages with setup.py making network calls: {suspicious}"
Expand Down Expand Up @@ -634,8 +641,8 @@ def test_no_unexpected_pth_files(self):
content = Path(pth_path).read_text(errors="replace")
if any(pattern.search(content) for pattern in SUSPICIOUS_PATTERNS):
risky.append(pth_path)
except (OSError, PermissionError):
pass
except (OSError, PermissionError) as exc:
warnings.warn(f"Could not read {pth_path}: {exc}", stacklevel=1)

assert not risky, f"CRITICAL: Unexpected .pth files with suspicious content: {risky}"

Expand All @@ -659,7 +666,8 @@ def test_no_credential_exfiltration_in_startup(self):

try:
content = pth_file.read_text(errors="replace")
except (OSError, PermissionError):
except (OSError, PermissionError) as exc:
warnings.warn(f"Could not read {pth_file}: {exc}", stacklevel=1)
continue

for target in SENSITIVE_EXFIL_TARGETS:
Expand Down
Loading