chore: Add requirements.txt to enable full test coverage#8
Merged
Desperado merged 1 commit intoQuality-Max:mainfrom Mar 26, 2026
Merged
Conversation
Add a requirements.txt so the scanner can validate its own dependency chain. Pins pytest to the exact tested version (8.4.0) and enables the 3 requirements-based tests that were previously skipped.
Contributor
|
Makes sense — this enables the 3 requirements integrity tests that were skipping. Full coverage now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a
requirements.txtwith the pinned pytest dependency so the scanner can validate its own supply chain — and so all 17 tests run instead of 14.Problem
Without a
requirements.txt, 3 tests are permanently skipped:These tests check for:
--require-hashesis used (advisory)git+,http://entries that bypass PyPI (supply chain risk);,&&,$() in requirements linesSkipping them means the scanner never validates its own dependency file — a supply chain security tool that doesn't eat its own dogfood.
Fix
Add
requirements.txtwith the exact pinned version:Why exact pin (
==) instead of range (>=)pyproject.tomlalready declarespytest>=7.0as the compatibility range for consumersrequirements.txtserves a different purpose: reproducible installs for development and CIrequirements.txtis the scanner's own recommendation (test_critical_packages_are_pinned)Result
All 17 tests now run: