-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example on dates data #57
Conversation
Codecov Report
@@ Coverage Diff @@
## main #57 +/- ##
=======================================
Coverage 93.90% 93.90%
=======================================
Files 15 15
Lines 1607 1607
=======================================
Hits 1509 1509
Misses 98 98 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor comments.
Example: Dates | ||
============== | ||
|
||
This example concerns itself with expressing ``Constraint`` s against data revolving |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you tend to have a space character when making plurals of "formatted" words? Like here in Constraint
s?
I saw the rendered version, and I think I can see a space between the word and the last letter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3. The minimum value in column ``date_from`` should be the first of January 2022. | ||
4. The maximum value in column ``date_to`` should be the 31st of January 2022. | ||
5. There is no gap between ``date_from`` and ``date_to``. In other words, every date | ||
of January can be assigned to at least one row. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of January can be assigned to at least one row. | |
of January has to be assigned to at least one row. |
Sadly, sqlite doesn't offer date data types - otherwise I would've added coded to actually run this, as we have in the companies example[0].
Eventually, one might find a way around this, e.g. by offering a script to upload data to a postgres database - as we do in the twitch example[1].
I figured this PR would be a good start. If someone feels like turning this into an executable specification in a follow-up PR, this would of course be highly appreciated.
Rendered version: https://datajudge--57.org.readthedocs.build/en/57/examples/example_dates.html
[0] https://datajudge.readthedocs.io/en/latest/examples/example.html
[1] https://datajudge.readthedocs.io/en/latest/examples/example_twitch.html