Rename argument for SKL compatibility (#822)

Quantco · Aug 7, 2024 · 5bcdf6f · 5bcdf6f
1 parent 4fc02bf
commit 5bcdf6f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -27,20 +27,23 @@ jobs:
       fail-fast: true
       matrix:
         include:
-          - { os: ubuntu-latest, environment: 'py39' }
           - { os: ubuntu-latest, environment: 'py310' }
           - { os: ubuntu-latest, environment: 'py311' }
           - { os: ubuntu-latest, environment: 'py312' }
-          - { os: ubuntu-latest, environment: 'oldies' }
           - { os: windows-latest, environment: 'py312' }
           - { os: macos-latest, environment: 'py312' }
+          - { os: ubuntu-latest, environment: 'oldies' }
+          - { os: ubuntu-latest, environment: 'nightly' }
     steps:
       - name: Checkout branch
         uses: actions/checkout@v4
       - name: Set up pixi
         uses: prefix-dev/setup-pixi@992a3081e2f87829e0fff9fb29f4fe6a5d1e80a2
         with:
           environments: ${{ matrix.environment }}
+      - name: Install nightlies
+        if: matrix.NOTE == 'Nightly Builds'
+        run: pixi run -e ${{ matrix.environment }} install-nightlies
       - name: Install repository
         run: pixi run -e ${{ matrix.environment }} postinstall
       - name: Run pytest

diff --git a/src/glum/_glm.py b/src/glum/_glm.py
@@ -72,7 +72,7 @@
     _safe_toarray,
 )
 
-if version.parse(skl.__version__) < version.parse("1.6"):
+if version.parse(skl.__version__).release < (1, 6):
     keyword_finiteness = "force_all_finite"
 else:
     keyword_finiteness = "ensure_all_finite"