Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower absolute tolerance in _find_alpha_index #908

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Lower absolute tolerance in _find_alpha_index #908

wants to merge 1 commit into from

Conversation

mlondschien
Copy link
Contributor

Sometimes I use really small values for alpha. The new atol is arbitrary. Is should be <= 1e-10 for float64.

In [2]: np.finfo(np.float32).eps
Out[2]: 1.1920929e-07

In [3]: np.finfo(np.float64).eps
Out[3]: 2.220446049250313e-16

Checklist

  • Added a CHANGELOG.rst entry

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcAntoineSchmidtQC MarcAntoineSchmidtQC Awaiting requested review from MarcAntoineSchmidtQC MarcAntoineSchmidtQC is a code owner

@jtilly jtilly Awaiting requested review from jtilly jtilly is a code owner

@lbittarello lbittarello Awaiting requested review from lbittarello lbittarello is a code owner

@stanmart stanmart Awaiting requested review from stanmart stanmart is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mlondschien