Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for full-feature inline #82

Open
2 of 3 tasks
jbachurski opened this issue May 18, 2023 · 0 comments
Open
2 of 3 tasks

Tracking issue for full-feature inline #82

jbachurski opened this issue May 18, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@jbachurski
Copy link
Collaborator

jbachurski commented May 18, 2023 •
edited
Loading

inline is currently missing:

  • Support for subgraphs (they should get prefixed properly, which ONNX renaming doesn't do)
  • Support for functions (such local/dependency functions should be propagated to the built model)
  • Capability not do add extraneous Identity nodes for all model input/outputs (requires better renaming capabilties)

Most of these can be fixed by reimplementing renaming values in graphs, as the ONNX feature (onnx.compose.add_prefix_graph) is rather lacking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbachurski