-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a custom graph renaming routine for inline #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks! I just have some minor suggestions/questions.
This is because not all inlined nodes/values have a respective Var/Node.
Could you expand on this a bit? Do you mean the nodes inside a subgraph?
Looks like due to the conda ONNX version bump, the CI is now failing on opset generation, so #83 will fix this :) |
I also added an explicit proto-based test, and one for subgraph lists as there is no practical example that can be constructed there (no node uses a list of subgraphs...). This is since we are now straying from the ONNX utility which would have some tests itself. Maybe I'll upstream the new one at some point?
@cbourjau Yeah - say an inlined |
Thanks for the clarification :) |
Addresses #82 by avoiding adding extraneous Identity nodes when inlining and supporting subgraph renaming
onnx.compose.add_prefix_graph
to make it more flexible.Var
/Node
, but are nevertheless marked as taken. This is because not all inlined nodes/values have a respectiveVar
/Node
.