Skip to content

Conversation

@mosteo
Copy link

@mosteo mosteo commented Jun 18, 2025

This is another attempt at #1176, with the feedback that was given there.

When the checkbox is enabled, the user is asked for the minimum number of comments. This info is shown as the summary of the checkbox, when it is enabled. This way there are no visible magic numbers or values with special significance.

A toast is shown when comments are filtered, just as a reminder that this filter is in effect.

Caveat: while I did #1176 entirely the old fashioned way, I used Claude for this one. It's been some years since I developed for Android so I'm unable to catch whether something isn't idiomatic nowadays. I did test and review everything though, without noticing anything suspicious.

When the checkbox is enabled, the user is asked for the minimum number of
comments. This info is shown as the summary of the checkbox, when it is
enabled.

A toast is shown when comments are filtered, just as a reminder that this
filter is in effect.
@mosteo mosteo force-pushed the feat/min-filter branch from 52fa931 to fc6b494 Compare June 18, 2025 08:36
@mosteo mosteo marked this pull request as draft June 18, 2025 09:17
@mosteo mosteo marked this pull request as ready for review June 19, 2025 07:50
@mosteo
Copy link
Author

mosteo commented Jun 19, 2025

Passing checks now. Sorry for the noise, I failed to open the PR in draft mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant