Skip to content

Remove departmental clown items#22

Open
CombustibleToast wants to merge 7 commits intoQuantumBlueSS14:masterfrom
CombustibleToast:qb-noclowns
Open

Remove departmental clown items#22
CombustibleToast wants to merge 7 commits intoQuantumBlueSS14:masterfrom
CombustibleToast:qb-noclowns

Conversation

@CombustibleToast
Copy link

Departmental clown masks are gone, sprites deleted and YML commented out. Loadout groups removed. Clown shoes removed from loadout groups. Clown mask and shoes removed from departmental drobes' contraband inventory. Botany and chef still can get the clown apron from the drobes' contraband inventory. Chaplain retains all clown apparel to fit the honkmother set.

don't look too hard at the diff size

@MattFright
Copy link
Collaborator

Sorry review took so long but this looks fine. I'm gonna wait for sage to give it a 2nd look since it's so many lines changes but it should be good to merge

name: loadout-group-botanist-shoes
loadouts:
- BrownShoes
- ClownShoesExpert

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed some clown shoes here!

@Sage-Jones
Copy link

Matt is a liar and a fraud! Couple things on this,

You'll need to merge our main into your pr's branch to fix the conflicts. Should also fix the integration test fail for the ComputerFundingAllocationBroken since we've already migrated that I think.
But most of the integration test fails are from maps having these prototypes still on them:
clown mask map prototypes to remove or migrate

You couuuld remove them manually if you'd like. But if you want to make it simple, just make a line for each in Resources/migration_qb.yml that migrates them to null or some other generic mask prototype.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants