build: restore Julia 1.10 LTS support - #148
Merged
Merged
Conversation
HarmonicBalance 0.17.0 is registered, so the [sources] pin to the now-deleted source branch is no longer needed.
Lower the julia compat back to 1.10. All dependencies still support it
and the full test suite passes there.
Two things that only the 1.10 job catches are fixed alongside:
- `unwrap` is owned by SymbolicUtils but was imported from, and
accessed through, Symbolics. `Base.which` resolves the owner
differently on 1.10, so ExplicitImports rejects it there.
- `get_variables(::Result)` repeated the `::Vector{Num}` return
annotation already declared on the `HomotopyContinuationProblem`
method. The redundant `convert` is one JET cannot prove away on
1.10, and inference gives `Vector{Num}` without it.
The lts entry in the CI matrix comes back once HarmonicBalance 0.17.1
is registered, since no released HarmonicBalance supports 1.10 yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lowers
juliacompat back to"1.10"(also indocs/Project.toml) and bumps the version to 0.5.2. Every dependency still declaresjulia = "1.10.0 - 1", and the full test suite passes on 1.10.11 locally.Two problems that only the 1.10 job surfaces are fixed here as well:
unwrapis owned bySymbolicUtilsbut was imported fromSymbolicsand accessed asSymbolics.unwrapin six places.Base.whichresolves the owner differently on 1.10, socheck_all_explicit_imports_via_ownersandcheck_all_qualified_accesses_via_ownersboth fail there.get_variables(::Result)repeated the::Vector{Num}return annotation that theHomotopyContinuationProblemmethod already declares. That extraconvertis one JET cannot prove away on 1.10.Base.return_typesgivesVector{Num}either way, so nothing changes at runtime. Worth noting thattest/code_quality.jlgates the JET testset onVERSION < v\"1.12.0-beta\", so JET has not run in CI at all since the matrix went 1.12-only.The
ltsentry in the CI matrix is deliberately not restored yet:test/runtests.jlloadsHarmonicBalance, and no registered HarmonicBalance version supports 1.10 until 0.17.1 is out. It follows in a separate PR.