ci: run tests and docs on lts again - #149
Merged
Merged
Conversation
HarmonicBalance 0.17.1 supports 1.10, so the test suite, which loads it, resolves on lts again.
Two more of these, both only caught by the 1.10 job:
- the LinearResponse submodule imported `unwrap` from Symbolics
rather than from SymbolicUtils, which owns it.
- QuantumCumulantsExt reached QuestBase through HarmonicSteadyState
even though it imports QuestBase directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HarmonicBalance 0.17.1 is registered and supports Julia 1.10, so
test/runtests.jl, which loads it, resolves onltsagain. Restoresltsin theTests.ymlmatrix (['lts', '1'], with coverage uploaded from the lts job) and inDocumentation.yml, matching the configuration from before the Symbolics 7 migration.Includes two ownership fixes that only the lts job catches, both verified locally on 1.10.11:
LinearResponsesubmodule importedunwrapfromSymbolicsrather than fromSymbolicUtils, which owns it.QuantumCumulantsExtreachedQuestBasethroughHarmonicSteadyStateeven though it already importsQuestBasedirectly.With these, all of
check_no_stale_explicit_imports,check_all_explicit_imports_via_owners,check_all_qualified_accesses_via_ownersandcheck_no_self_qualified_accessespass on 1.10 forHarmonicSteadyStateand all five of its extension modules. No version bump: these are import-provenance changes with no runtime effect.Note this also re-enables the JET testset, which
test/code_quality.jlgates onVERSION < v\"1.12.0-beta\"and which has therefore not run in CI since the matrix went 1.12-only.JET.report_package(HarmonicSteadyState)reports no errors on 1.10.