Implement embed functions for Gaussian unitaries, channels, and linear combinations #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r combinations (issue QuantumSavory#82) - Add embed support for GaussianUnitary (QuadPair and QuadBlock bases) - Properly pads displacement and symplectic matrices - Preserves ħ parameter - Add embed support for GaussianChannel (QuadPair and QuadBlock bases) - Embeds displacement, transform, and noise matrices - Preserves ħ parameter - Add embed support for GaussianLinearCombination - Embeds each state in the combination while preserving coefficients - Add comprehensive tests for all three embed implementations - Test single and multi-mode embedding - Verify correct behavior via partial trace - Include assertion error cases for invalid inputs All tests pass successfully.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
=======================================
Coverage ? 97.50%
=======================================
Files ? 19
Lines ? 2608
Branches ? 0
=======================================
Hits ? 2543
Misses ? 65
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
apkille
approved these changes
Jan 5, 2026
Member
apkille
left a comment
apkille
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add embed support for GaussianUnitary (QuadPair and QuadBlock bases)
Add embed support for GaussianChannel (QuadPair and QuadBlock bases)
Add embed support for GaussianLinearCombination
Add comprehensive tests for all three embed implementations
All tests pass successfully.
Fixes #82
If you want to submit an unfinished piece of work in order to get comments and discuss, please mark the pull request as a draft and ping the repository maintainer.
Please address only one topic or issue per pull request! Many small PRs are much easier to review and merge than one large PR.
Before merging, all changes and new functionality should be marked in the CHANGELOG file, but feel free to just leave your CHANGELOG notes in the PR description, to avoid merge conflicts with other requests modifying that file. The maintainer will add these CHANGELOG notes for you if you do so.
Before considering your pull request ready for review and merging make sure that all of the following are completed (please keep the clecklist as part of your PR):
If possible, keep your git history not too wild (rebase and squash commits, keep commits small and semantically separated) so that review is easier.