Skip to content

Add no-go theorems section and missing Werner et al. 2001 reference #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
apkille merged 6 commits into from
Jan 8, 2026
Merged

Add no-go theorems section and missing Werner et al. 2001 reference #94

apkille merged 6 commits into from
Jan 8, 2026

Conversation

@arnavk23
Copy link
Contributor

@arnavk23 arnavk23 commented Jan 6, 2026 •
edited
Loading

  • Added Werner et al. 2001 paper on bound entangled states to references
  • Created dedicated "No-Go Theorems and Fundamental Limitations" section in bibliography
  • Included key papers discussing limitations of Gaussian operations and distillation
  • The code is properly formatted and commented.
  • Substantial new functionality is documented within the docs.
  • All new functionality is tested.
  • All of the automated tests on github pass.
  • We recently started enforcing formatting checks. If formatting issues are reported in the new code you have written, please correct them. There will be plenty of old code that is flagged as we are slowly transitioning to enforced formatting. Please do not worry about or address older formatting issues -- keep your PR just focused on your planned contribution.

@arnavk23
Add no-go theorems section and missing Lund et al. 2001 reference (Qu…
e6fd685 
…antumSavory#40)

- Added Lund et al. 2001 paper on continuous-variable entanglement to references
- Created dedicated "No-Go Theorems and Fundamental Limitations" section in bibliography
- Included key papers discussing limitations of Gaussian operations and distillation
@codecov
Copy link

codecov bot commented Jan 6, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@fe93427). Learn more about missing BASE report.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage        ?   97.17%           
=======================================
  Files           ?       19           
  Lines           ?     2623           
  Branches        ?        0           
=======================================
  Hits            ?     2549           
  Misses          ?       74           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arnavk23
Fix incorrect paper reference for issue QuantumSavory#40 - use correc…
170f619 
…t Werner & Wolf 2001 paper

- Corrected reference from fictitious Lund et al. 2001 to actual "Bound Entangled Gaussian States" by Werner and Wolf (PhysRevLett.86.3658)
- Updated bibliography to use werner2001 key
- Paper discusses fundamental limitations of Gaussian operations in no-go theorems section
@arnavk23 arnavk23 changed the title Add no-go theorems section and missing Lund et al. 2001 reference Add no-go theorems section and missing Werner et al. 2001 reference Jan 6, 2026
apkille
apkille requested changes Jan 6, 2026
View reviewed changes
apkille
apkille reviewed Jan 6, 2026
View reviewed changes
@apkille
Copy link
Member

apkille commented Jan 6, 2026

Removed a redundant description that doesn't match the style of the rest of the suggested readings section.

@arnavk23
Copy link
Contributor Author

arnavk23 commented Jan 6, 2026

Thank you for your review. I agree with you on the changes made. This feels better than the earlier version.

@apkille apkille merged commit 2538a09 into QuantumSavory:main Jan 8, 2026
14 of 15 checks passed
@arnavk23 arnavk23 deleted the issue-40-nogothm branch January 8, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apkille apkille apkille requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arnavk23 @apkille