Avoid reusing disposable VM names for some predefined time #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not |
Oh. Forgot that. We had discussed datetime module. When I switched to time module (since it was already used in the code), I forgot to re-implement monotonic. I will amend the code and force push in a second. |
alimirjamali
force-pushed
the
Issue-8512
branch
2 times, most recently
from
726d97d
to
7247c3c
Compare
|
Making Pylint happy |
ben-grande
reviewed
Jul 1, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #603 +/- ##
==========================================
+ Coverage 69.35% 69.36% +0.01%
==========================================
Files 58 58
Lines 11919 11929 +10
==========================================
+ Hits 8266 8275 +9
- Misses 3653 3654 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
The change itself looks good, but can you add a unit test? Tests for VMCollection are in qubes/tests/app.py. And you can mock the |
Sure. Will work on it. |
I added the Unit Test in the second commit @marmarek . Unit test number 999999 is inspired by the Dilbert comic strip URL which was added to the original function by fepitre. |
marmarek
reviewed
Jul 2, 2024
|
Ok. Test completed successfully. Here is the link: https://gitlab.com/QubesOS/qubes-core-admin/-/jobs/7250348262#L3221 |
This was referenced Jul 3, 2024
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024070322-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024062115-4.3&flavor=update
Failed tests11 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/103633#dependencies 5 fixed
Unstable tests
|
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: QubesOS/qubes-issues#8512