Remove competitors

[fvacek]

Competitors perspective removed, functionality moved to Runs:

• competitors statistics report
• set class in selected rows context menu
• ranking_pos table column
• new entries can be done using insert into table Runs

[arnost00]

Before merging, we need to update translations.

[fvacek]

It seems that the "Draw class" and "Remove drawing" buttons do not call the appropriate action. I was not able to find in the original code how the connection is implemented, whether it relies on automatic connection in Qt. It worked before the merge of runs and competitors.

Tested on action build & local build from this branch.

fixed in 8858cc4

[fvacek]

How to set start time for new competitor in "Edit competitor" dlg? Field "Runs" is empty.

1. Button Save will fill runs table, this should be automated somehow, now I don't know how.
2. double click on start_time will open free (vacant) starting times to assign.

[fvacek]

In runs UI is missing menu item "Stations"->"Backup memory"

I'm not sure, if backup memory readout is or was working. Does it worth to keep it?

[arnost00]

In runs UI is missing menu item "Stations"->"Backup memory"

I'm not sure, if backup memory readout is or was working. Does it worth to keep it?

As i wrote earlier : I'm not sure about "Stations"->"Backup memory", maybe its old and unused.
Do we know of anyone who used this functionality?

[lukaskett]

I'm not sure, if backup memory readout is or was working. Does it worth to keep it?

As i wrote earlier : I'm not sure about "Stations"->"Backup memory", maybe its old and unused. Do we know of anyone who used this functionality?

We were using backup memory function few years ago. It can be used only for event in contact mode (contactless punch is not stored in the unit memory). There is no need to keep the function in my point of view.

[fvacek]

In runs table widget is missing column "IOF ID"

fixed in 185c02a

[fvacek]

After commit f7dcd70 I cannot add or remove competitor by [+] [-] buttons.

Button [-] in RunsWidget::editCompetitors ends on

		if(sel_rows.count() <= 1)
			return;

Button [+] in TableView::insertRow call emit editRowInExternalEditor, which is comented in RunsWidget::RunsWidget on line

// connect(ui->wRunsTableWidget->tableView(), &qfw::TableView::editRowInExternalEditor, this, &RunsWidget::editCompetitor, Qt::QueuedConnection);

fixed in 7273ff5

[arnost00]

Nice work :)
Thanks