Fix Clang tidy errors #1011
Merged
Fix Clang tidy errors #1011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnost00
reviewed
May 20, 2025
Collaborator
There was a problem hiding this comment.
Accidentally added .orig file.
arnost00
reviewed
May 20, 2025
Collaborator
There was a problem hiding this comment.
: Super(parent),
There remains a comma at the end of line.
Build fail on it.
arnost00
reviewed
May 20, 2025
| classes << age; | ||
| } | ||
| std::sort(classes.begin(), classes.end()); | ||
| std::ranges::sort(classes,); |
Collaborator
There was a problem hiding this comment.
Extra comma
Also on the lines 363, 434
And there is more ...
fvacek
force-pushed
the
clang-tidy-in-progress
branch
2 times, most recently
from
7af03b4 to
191ade2
Compare
fvacek
force-pushed
the
clang-tidy-in-progress
branch
from
191ade2 to
fb1e44a
Compare
fvacek
force-pushed
the
clang-tidy-in-progress
branch
from
fc7d93b to
b82ef20
Compare
fvacek
force-pushed
the
clang-tidy-in-progress
branch
from
b82ef20 to
73edb7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.