Skip to content

Some courses invisible in course edit form #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fvacek merged 2 commits into from
Oct 3, 2025
Merged

Some courses invisible in course edit form #1040

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa21e58
Some courses invisible in course edit form #1038
fvacek Oct 2, 2025
3bcd337
Merge branch 'qe3' into 1038-some-courses-invisible-in-course-edit-form
fvacek Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion quickevent/app/quickevent/plugins/Classes/src/classeswidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,8 @@ void ClassesWidget::settleDownInPartWidget(::PartWidget *part_widget)
void ClassesWidget::edit_courses()
{
qf::gui::dialogs::Dialog dlg(QDialogButtonBox::Close, this);
auto *w = new EditCoursesWidget();
int stage_id = selectedStageId();
auto *w = new EditCoursesWidget(stage_id);
dlg.setCentralWidget(w);
dlg.exec();
reload();
Expand Down
4 changes: 2 additions & 2 deletions quickevent/app/quickevent/plugins/Classes/src/editcourseswidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class CoursesTableModel : public qfm::SqlTableModel
}
};

EditCoursesWidget::EditCoursesWidget(QWidget *parent)
EditCoursesWidget::EditCoursesWidget(int stage_id, QWidget *parent)
: Super(parent)
, ui(new Ui::EditCoursesWidget)
{
Expand Down Expand Up @@ -122,7 +122,7 @@ EditCoursesWidget::EditCoursesWidget(QWidget *parent)
.join("classdefs.classId", "classes.id")
.join("classes.id", "competitors.classId")
.joinRestricted("competitors.id", "runs.competitorId", "runs.isRunning")
.where("classdefs.stageId=runs.stageId")
.where("classdefs.stageId=" QF_IARG(stage_id))
.groupBy("courses.id")
.orderBy("courses.name");

Expand Down
2 changes: 1 addition & 1 deletion quickevent/app/quickevent/plugins/Classes/src/editcourseswidget.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class EditCoursesWidget : public qf::gui::framework::DialogWidget
private:
typedef qf::gui::framework::DialogWidget Super;
public:
explicit EditCoursesWidget(QWidget *parent = 0);
explicit EditCoursesWidget(int stage_id, QWidget *parent = 0);
~EditCoursesWidget() Q_DECL_OVERRIDE;

void editCourseCodes(const QModelIndex &ix);
Expand Down
2 changes: 1 addition & 1 deletion quickevent/app/quickevent/src/appversion.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#pragma once

#define APP_VERSION "3.4.5"
#define APP_VERSION "3.4.7"