QE3 - added OFeed platform support #997
Conversation
without compression, with fake filename that must be present
working upload (regular and after edit db event), readout event have to be tested todo: download data from OF
add a new competitor (onfly is start time is inserted) fix error eith running time that wasn't converted to seconds from miliseconds iof status fix for time initial value -1 that caused OK status that was wrong for a new or updated competitor
fvacek
left a comment
fvacek
left a comment
There was a problem hiding this comment.
Please fix indentation and read also QE coding style https://github.com/Quick-Box/quickevent/wiki/Code-style
quickevent/app/quickevent/plugins/Event/src/services/ofeed/ofeedclient.cpp
Outdated
Show resolved
Hide resolved
quickevent/app/quickevent/plugins/Event/src/services/ofeed/ofeedclient.cpp
Outdated
Show resolved
Hide resolved
| // qf::core::utils::ConfigCLIOptions | ||
| // cliOptions()->eventName() | ||
| qf::core::sql::Query q_schema; | ||
| q_schema.exec("select current_schema", qf::core::Exception::Throw); |
There was a problem hiding this comment.
This is too cumbersome way to find out if competitor was edited or inserted, we should better add this flag to DB_EVENT payload data
There was a problem hiding this comment.
This also will not work with SQLite
There was a problem hiding this comment.
agree, a new db event will solve it in much better way, but adding a new db event was too big task for me to be honest.
| running_time = running_time_variant.toInt(); | ||
| } | ||
|
|
||
| // Status |
There was a problem hiding this comment.
There is a RunStatus utility class in libquickevent for this already
There was a problem hiding this comment.
RunStatus is not operating with Inactive status which is important as initial state for the platform
There was a problem hiding this comment.
What Inactive exactly means?
innactive == RunStatus WHERE all fields are false
in my understanding
There was a problem hiding this comment.
From IOF.xsd, link
<xsd:enumeration value="Inactive">
<xsd:annotation>
<xsd:documentation>
Has not yet started.
</xsd:documentation>
</xsd:annotation>
</xsd:enumeration>so it makes sense that all fields are false
There was a problem hiding this comment.
Then RunStatus can be used, we can introduce RunStatus::isInactive()
|
moved to #1009 |
2 participants
The service features:
TODO: