Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fallback name proposal and name proposal save bypass #240

Merged
merged 18 commits into from
Dec 17, 2024
Merged

fallback name proposal and name proposal save bypass #240

merged 18 commits into from
Dec 17, 2024

Conversation

ix0rai
Copy link
Member

@ix0rai ix0rai commented Nov 9, 2024 •
edited
Loading

implements #239

  • adds a bypassValidation() boolean in NameProposalService
    • this boolean allows that service to ignore the regular checks performed on proposed mappings (validating that they either remove a mapping or provide a proposed mapping)
    • this is essential for part of move QM onto a mojmap base quilt-mappings#660, since the mappings proposed for classes to apply moj packages have to be TokenType.DEOBFUSCATED
  • adds a fallback() boolean to NameProposalService
    • fallback names will not count towards stats by default
    • fallback names will have a different colour in the UI
    • fallback names do not have their own token types, and are expected to be less reliably high-quality names than normal proposed mappings

@ix0rai ix0rai added enhancement New feature or request backend affects the enigma backend wip in progress labels Nov 9, 2024
@ix0rai ix0rai mentioned this pull request Nov 9, 2024
Open
4 tasks
@ix0rai ix0rai marked this pull request as ready for review December 4, 2024 01:27
@ix0rai ix0rai added user interface affects the enigma ui and removed wip in progress labels Dec 4, 2024
@ix0rai ix0rai changed the base branch from master to develop/2.6 December 6, 2024 23:41
@ix0rai ix0rai mentioned this pull request Dec 8, 2024
Merged
IotaBread
IotaBread approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@IotaBread IotaBread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

enigma/src/test/java/org/quiltmc/enigma/name_proposal/TestFallbackNameProposal.java Show resolved Hide resolved
@ix0rai ix0rai merged commit dda4efe into QuiltMC:develop/2.6 Dec 17, 2024
2 checks passed
@ix0rai ix0rai mentioned this pull request Jan 6, 2025
Merged
ix0rai added a commit that referenced this pull request Jan 9, 2025
@ix0rai
fallback name proposal and name proposal save bypass (#240)
61049a8 
* add methods and start work on tests

* actually use that method oops

* implement bypassValidation()

* implement fallback for stats

* checkstyle tests

* store a full `EntryMapping` in `TranslateResult`

* add highlighting for fallback mappings

* fix crash with trailing commas in profile json

* add test proposer for fallback
- fix highlighting
- only propose names for the first parameter of each method in test:parameters

* orange!

* good looking colors for fallback

* checkstyle

* checkstyle

* rethrow exceptions in tests

* fix dynamic proposal not accounting for unchecked

* fix dynamic proposal putting obf mappings in the wrong tree

* checkstyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supersaiyansubtlety supersaiyansubtlety supersaiyansubtlety left review comments

@IotaBread IotaBread IotaBread approved these changes

Assignees
No one assigned
Labels
backend affects the enigma backend enhancement New feature or request user interface affects the enigma ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ix0rai @supersaiyansubtlety @IotaBread