Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add downloadMojangMappings task #668

Open
wants to merge 5 commits into
base: 25w05a
Choose a base branch
from
Open

Add downloadMojangMappings task #668

wants to merge 5 commits into from

Conversation

supersaiyansubtlety
Copy link
Member

@supersaiyansubtlety supersaiyansubtlety commented Nov 27, 2024 •
edited
Loading

Adds a downloadMojangMappings task in preparation for #660.

Downloads client and server mappings.

Mappings aren't available for all versions; if unavailable, warnings are logged.

Behavior for missing mappings may need adjusting depending on what tasks end up depending on downloadMojangMappings.

@supersaiyansubtlety supersaiyansubtlety added enhancement new feature or request t: toolchain changes to the quilt mappings toolchain reviews needed please review this PR s: small PRs with less than 200 lines labels Nov 27, 2024
@supersaiyansubtlety supersaiyansubtlety self-assigned this Nov 27, 2024
@supersaiyansubtlety supersaiyansubtlety added the update-base used to notify github actions that the base branch should be updated label Nov 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚀 Target branch has been updated to 1.21.4-pre2

@github-actions github-actions bot changed the base branch from 1.21.4-pre1 to 1.21.4-pre2 November 27, 2024 05:55
@github-actions GitHub Actions
Copy link
Contributor

🚨 Please fix merge conflicts before this can be merged

@github-actions github-actions bot added v: snapshot targets a snapshot version of minecraft outdated this pull request hasn't been updated to the latest version or has merge conflicts and removed update-base used to notify github actions that the base branch should be updated labels Nov 27, 2024
@supersaiyansubtlety supersaiyansubtlety force-pushed the gradle-cleanup+mojmap-download branch from c38bfc4 to da99c88 Compare November 27, 2024 07:33
@supersaiyansubtlety supersaiyansubtlety removed the outdated this pull request hasn't been updated to the latest version or has merge conflicts label Nov 27, 2024
@ix0rai
Copy link
Member

ix0rai commented Nov 29, 2024

looks good! i won't be merging this until the details of how this will work on the plugin side are figured out

@supersaiyansubtlety supersaiyansubtlety added the update-base used to notify github actions that the base branch should be updated label Dec 2, 2024
@github-actions github-actions bot changed the base branch from 1.21.4-pre2 to 1.21.4-rc3 December 2, 2024 23:42
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

🚀 Target branch has been updated to 1.21.4-rc3

@github-actions github-actions bot removed the update-base used to notify github actions that the base branch should be updated label Dec 2, 2024
@supersaiyansubtlety supersaiyansubtlety added the update-base used to notify github actions that the base branch should be updated label Dec 4, 2024
@github-actions github-actions bot changed the base branch from 1.21.4-rc3 to 1.21.4 December 4, 2024 00:35
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

🚀 Target branch has been updated to 1.21.4

@github-actions github-actions bot removed the update-base used to notify github actions that the base branch should be updated label Dec 4, 2024
@ix0rai ix0rai added the update-base used to notify github actions that the base branch should be updated label Jan 15, 2025
@github-actions github-actions bot changed the base branch from 1.21.4 to 25w02a January 15, 2025 23:19
@github-actions GitHub Actions
Copy link
Contributor

🚀 Target branch has been updated to 25w02a

@github-actions github-actions bot removed the update-base used to notify github actions that the base branch should be updated label Jan 15, 2025
@ix0rai ix0rai added the update-base used to notify github actions that the base branch should be updated label Feb 6, 2025
@github-actions github-actions bot changed the base branch from 25w02a to 25w03a February 6, 2025 01:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

🚀 Target branch has been updated to 25w03a

@github-actions github-actions bot removed the update-base used to notify github actions that the base branch should be updated label Feb 6, 2025
@ix0rai ix0rai added the update-base used to notify github actions that the base branch should be updated label Feb 6, 2025
@github-actions github-actions bot changed the base branch from 25w03a to 25w04a February 6, 2025 02:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

🚀 Target branch has been updated to 25w04a

@ix0rai ix0rai added update-base used to notify github actions that the base branch should be updated and removed update-base used to notify github actions that the base branch should be updated labels Feb 6, 2025
@github-actions github-actions bot changed the base branch from 25w04a to 25w05a February 6, 2025 03:12
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

🚀 Target branch has been updated to 25w05a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ix0rai ix0rai Awaiting requested review from ix0rai

Assignees

@supersaiyansubtlety supersaiyansubtlety

Labels
enhancement new feature or request reviews needed please review this PR s: small PRs with less than 200 lines t: toolchain changes to the quilt mappings toolchain update-base used to notify github actions that the base branch should be updated v: snapshot targets a snapshot version of minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supersaiyansubtlety @ix0rai