Add image extraction to PDF. Polish code #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @dSupertramp this is awesome! Could you try to use something else than FITZ ? Its license is AGPL, meaning it can't be used in production if you don't have a commercial license with them. |
Done! I used pypdf |
|
@chloedia @AmineDiro can you test ? :) |
|
@dSupertramp it seems you forgot to add it to the dependencies ;) |
AmineDiro
reviewed
Jun 21, 2024
| @@ -19,6 +19,7 @@ poppler-utils = "*" | |||
| langchain-openai = "*" | |||
| langchain-core = "*" | |||
| python-dotenv = "*" | |||
| pypdf = "*" | |||
There was a problem hiding this comment.
Should probably fix the version
Co-authored-by: AmineDiro <[email protected]>
Co-authored-by: AmineDiro <[email protected]>
|
Everything solved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone! Danilo's here
I added the extraction of the images from PDF (images are saved in a local folder)
I also cleaned the code a little bit
Thanks for all!