feat(acp): add MiniMax Code backend - #309
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The MiniMax backend integration is consistently wired through catalog/config/driver layers with explicit permission-mode mapping and broad automated test coverage for the new behavior.
Pull request overview
Adds MiniMax Code as a first-class local ACP (stdio) backend (mcode acp) integrated into the shared backend catalog so the CLI, desktop UI, and Gateway can detect/install/onboard it consistently, including support for mapping “full permission” to MiniMax’s native permissionMode=bypassPermissions.
Changes:
- Add MiniMax backend metadata (install steps, onboarding command, env/workspace wiring) and register it across runtime config and UI labels.
- Add ACP driver/profile support for running
mcode acp, including permission-mode mapping tobypassPermissions. - Expand regression coverage across catalog/config/selection/install/environment/managed-backend behavior and fix Node.js 26 TUI test output buffering.
File summaries
| File | Description |
|---|---|
| tui/test/index.test.mjs | Fixes stdout buffering assertions by draining all available chunks under newer Node stream behavior. |
| test/backend-catalog.test.mjs | Verifies MiniMax backend definition (label, command, integration, permissions, skills=null). |
| shared/runtime-environment.mjs | Adds MiniMax workspace resolution and exposes it via loadRuntimeEnvironment output. |
| shared/backend-catalog.mjs | Adds MiniMax backend catalog entry including install/onboarding metadata and env prefix. |
| server/test/managed-backend.test.mjs | Ensures MiniMax is treated as an additional managed ACP backend. |
| server/test/dependency-boundaries.test.mjs | Updates “named backend” detection regex to include MiniMax. |
| server/test/config.test.mjs | Extends workspace/model-mapping/config-override behaviors to include MiniMax. |
| server/test/backend-onboarding.test.mjs | Adds expected onboarding command for MiniMax (mcode login). |
| server/test/backend-install.test.mjs | Adds install support expectations for MiniMax (script URLs + confirmation). |
| server/test/backend-environment.test.mjs | Validates MiniMax env projection stays isolated from unrelated credential namespaces. |
| server/test/agent-client-selection.test.mjs | Adds MiniMax to protocol selection matrix and workspace directory expectations. |
| server/test/acp-backend-adapter.test.mjs | Verifies MiniMax ACP profile uses permissionMode=bypassPermissions when “full” is requested. |
| server/src/core/config.mjs | Adds MiniMax backend config (model, workspace, cliPath via MINIMAX_CODE_BIN). |
| server/src/agent/backends/local-acp.mjs | Registers MiniMax local ACP driver (mcode acp) with session option mapping for “full”. |
| README.md | Adds MiniMax Code to backend support table. |
| README_ZH.md | Adds MiniMax Code to backend support table (ZH). |
| PRIVACY.md | Updates backend examples list to include Qwen Code + MiniMax Code. |
| package.json | Adds minimax-code keyword. |
| docs/index.zh.md | Mentions MiniMax Code among supported agents. |
| docs/index.md | Mentions MiniMax Code among supported agents. |
| docs/gateway-protocol.zh.md | Adds MiniMax Code to reference backend examples. |
| docs/gateway-protocol.md | Adds MiniMax Code to reference backend examples. |
| docs/configuration/backend.zh.md | Adds MiniMax install/config docs, and clarifies skills.sh limitation for MiniMax. |
| docs/configuration/backend.md | Adds MiniMax install/config docs, and clarifies skills.sh limitation for MiniMax. |
| docs/backends/overview.zh.md | Adds MiniMax to backend overview table and clarifies skill management behavior. |
| docs/backends/overview.md | Adds MiniMax to backend overview table and clarifies skill management behavior. |
| docs/architecture/overview.zh.md | Adds MiniMax Code to architecture backend examples. |
| docs/architecture/overview.md | Adds MiniMax Code to architecture backend examples. |
| docs/architecture/deep-dive.zh.md | Adds MiniMax Code to ACP backend lists and MCP-injection description. |
| docs/architecture/deep-dive.md | Adds MiniMax Code to ACP backend lists and MCP-injection description. |
| desktop/src/settings.js | Adds MiniMax Code label mapping in backend settings UI. |
| cli/test/runtime.test.mjs | Adds MiniMax to named-local-ACP backend resolution test matrix. |
| cli/test/runtime-environment.test.mjs | Ensures MiniMax workspace is included/excluded appropriately in runtime env setup. |
| cli/test/backend-setup.test.mjs | Adds MiniMax installation detection test via mcode presence. |
| cli/test/arguments.test.mjs | Allows --backend minimax as a named local ACP backend without backend URL. |
| CHANGELOG.md | Documents MiniMax backend support and ownership of login/model/provider settings. |
| .env.example | Adds MiniMax to backend list and documents MINIMAX_CODE_* configuration knobs. |
Review details
- Files reviewed: 37/37 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟢 Approval recommended
The MiniMax backend is integrated consistently across catalog/driver/config/docs and is backed by targeted regression tests, with no confirmed functional issues in the reviewed diffs.
Review details
- Files reviewed: 37/37 changed files
- Comments generated: 0 new
- Review effort level: Lite
Summary
mcode acp.permissionMode=bypassPermissionssession option.Validation
npm run lintnpm testnpm run buildnpm run release:checkgit diff --checkmcode0.2.7).Compatibility and Security
package-lock.jsonand TUI production code are not included.