Skip to content

Fix issue #654 Respect --model parameter when using custom base URL #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix issue #654 Respect --model parameter when using custom base URL #694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/core/src/core/contentGenerator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,10 @@ export function createContentGeneratorConfig(
if (authType === AuthType.USE_OPENAI && openaiApiKey) {
contentGeneratorConfig.apiKey = openaiApiKey;
contentGeneratorConfig.baseUrl = openaiBaseUrl;
contentGeneratorConfig.model = openaiModel || DEFAULT_QWEN_MODEL;
// Prioritize: 1) Model from config (CLI --model), 2) OPENAI_MODEL env var, 3) DEFAULT_QWEN_MODEL
// Only use effectiveModel if it came from config, not from DEFAULT_GEMINI_MODEL fallback
const modelFromConfig = config.getModel();
contentGeneratorConfig.model = modelFromConfig || openaiModel || DEFAULT_QWEN_MODEL;

return contentGeneratorConfig;
}
Expand All @@ -143,9 +146,10 @@ export function createContentGeneratorConfig(
// Set a special marker to indicate this is Qwen OAuth
contentGeneratorConfig.apiKey = 'QWEN_OAUTH_DYNAMIC_TOKEN';

// Prefer to use qwen3-coder-plus as the default Qwen model if QWEN_MODEL is not set.
// Prioritize: 1) Model from config (CLI --model), 2) QWEN_MODEL env var, 3) DEFAULT_QWEN_MODEL
const modelFromConfig = config.getModel();
contentGeneratorConfig.model =
process.env['QWEN_MODEL'] || DEFAULT_QWEN_MODEL;
modelFromConfig || process.env['QWEN_MODEL'] || DEFAULT_QWEN_MODEL;

return contentGeneratorConfig;
}
Expand Down