feat: Create a compiled release package #685
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OulipianSummer
changed the title
OulipianSummer
force-pushed
the
compiled_release
branch
from
224c92f to
3f04a23
Compare
🦋 Changeset detectedLatest commit: 5ba71ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
OulipianSummer
force-pushed
the
compiled_release
branch
4 times, most recently
from
e5c250f to
7370eb1
Compare
OulipianSummer
force-pushed
the
compiled_release
branch
from
7370eb1 to
979e705
Compare
|
Opening this for review. My ability to test the CI workflow itself is limited, but this configuration should upload a compiled lib archive to the release. I lack the insight to know exactly how this would function in your CI pipeline, so any eyes on this to spot any obvious bugs would be appreciated. There is a failed lint job that appears to be an upstream issue with the work on main, but it is not related to this work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
This is an initial step towards resolving #680.
This pull request adds a build step onto the
build.prodcommand that creates alib.tar.gzfile with the compiled code, but is gitignored, so it doesn't make its way back into the repo.What is missing is a github/changeset step that uploads that file to the tagged github release. This is something I don't have good insight on. The changeset build step uploads the compiled code to npm. When I test this build process on my fork, the ci jobs fail because I don't have access to the npm pipeline, which is good. However, it makes it hard to debug this.
This issue changesets/changesets#1366 seems to offer a solid guide on how to do this using a separate action.
Use cases and why
Resolves an ongoing issue where the partytown library is not released via github as a compiled asset.
Checklist: