Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qwik-city): allow qwik to process .mdx files #6988

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wmertens
Copy link
Member

this allows embedded qrl functionality.

This may or may not be a good idea.

this allows embedded qrl functionality
@wmertens wmertens requested a review from a team as a code owner October 17, 2024 20:37
Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: 0d7b755

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik-city Patch
eslint-plugin-qwik Patch
@builder.io/qwik Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 17, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@6988
npm i https://pkg.pr.new/@builder.io/qwik-city@6988
npm i https://pkg.pr.new/eslint-plugin-qwik@6988
npm i https://pkg.pr.new/create-qwik@6988

commit: 0d7b755

@shairez
Copy link
Contributor

shairez commented Oct 17, 2024

@wmertens can you elaborate on it a bit?
We can already embed Qwik components in mdx files no?

@thejackshelton
Copy link
Member

@wmertens can you elaborate on it a bit? We can already embed Qwik components in mdx files no?

@shairez

This might be related to the session wout and I paired on, where specifically in Qwik UI MDX breaks in v2 because of the specific recma config, which has a qrl in the mdx.

e.g what allows us to do the custom styling for each mdx tag (blockquote, paragraph, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants