Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Ensure q:key is included when a user adds a new key #7049

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

JerryWu1234
Copy link
Contributor

image

Fix ensure q:key is included when a user adds a new key

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@JerryWu1234 JerryWu1234 requested a review from a team as a code owner November 7, 2024 06:03
Copy link

changeset-bot bot commented Nov 7, 2024

⚠️ No Changeset found

Latest commit: 89c1e78

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Nov 7, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7049
npm i https://pkg.pr.new/@builder.io/qwik-city@7049
npm i https://pkg.pr.new/eslint-plugin-qwik@7049
npm i https://pkg.pr.new/create-qwik@7049

commit: 89c1e78

@wmertens
Copy link
Member

This looks correct, but why is this needed? Is there a bug related to it?

Keys can be really long and this would potentially add a lot of bytes to the HTML output.

@JerryWu1234
Copy link
Contributor Author

This looks correct, but why is this needed? Is there a bug related to it?

Keys can be really long and this would potentially add a lot of bytes to the HTML output.

#7047

image

it's weird,

When a list is rendered on the client side, adding more items to the list triggers a re-render. However, only the first

  • element has a q:key property in the initial render, while the rest lack it.

  • Copy link
    Contributor

    github-actions bot commented Nov 15, 2024

    built with Refined Cloudflare Pages Action

    ⚡ Cloudflare Pages Deployment

    Name Status Preview Last Commit
    qwik-docs ✅ Ready (View Log) Visit Preview 89c1e78

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants