Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Remove use of SourceInterface for CCvar #804

Merged
merged 3 commits into from
Sep 2, 2024
Merged

core: Remove use of SourceInterface for CCvar #804

merged 3 commits into from
Sep 2, 2024

Conversation

F1F7Y
Copy link
Member

@F1F7Y F1F7Y commented Aug 31, 2024

Code review:

Look at code

Testing:

Run commands like help or find that use g_pCVar.

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Aug 31, 2024
@F1F7Y F1F7Y changed the title core: Remove use of SourceInterface in convar.cpp core: Remove use of SourceInterface for CCvar Aug 31, 2024
GeckoEidechse
GeckoEidechse approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing as per instructions

@GeckoEidechse GeckoEidechse added almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge and removed needs testing Changes from the PR still need to be tested labels Sep 2, 2024
ASpoonPlaysGames
ASpoonPlaysGames approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, g_pCVarInterface was basically never used anyway since we just used g_pCVar instead.

@GeckoEidechse GeckoEidechse removed needs code review Changes from PR still need to be reviewed in code almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Sep 2, 2024
@GeckoEidechse GeckoEidechse merged commit 669fdae into R2Northstar:main Sep 2, 2024
6 checks passed
wolf109909 pushed a commit to R2NorthstarCN/NorthstarLauncher that referenced this pull request Sep 8, 2024
@F1F7Y @wolf109909
core: Remove use of SourceInterface for CCvar (R2Northstar#804)
839d0cd 
`SourceInteface` class goes back to icepick and is not good. We have a replacement, let's use it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

@ASpoonPlaysGames ASpoonPlaysGames ASpoonPlaysGames approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@F1F7Y @GeckoEidechse @ASpoonPlaysGames