Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helping section #196

Merged
merged 33 commits into from
Dec 19, 2023
Merged

Add helping section #196

merged 33 commits into from
Dec 19, 2023

Conversation

itscynxx
Copy link
Contributor

Pretty sure this is my biggest PR yet, the time it takes to get fully merged will probably reflect this

There are a few parts I'm iffy on (notably the hyperlink on line 100. Though for this one, hovering over the first [ shows that it's "linked" to the proper ] for the image so it might work)

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna leave it at the line break stuff for now cause if suggest any changes and you push line breaks first, all my suggestions will merge conflict and cannot be auto-applied anymore ^^

docs/helping.md Outdated Show resolved Hide resolved
docs/SUMMARY.md Outdated Show resolved Hide resolved
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much to read so I just did part of it for now ^^"

docs/helping.md Outdated Show resolved Hide resolved
docs/helping.md Outdated Show resolved Hide resolved
docs/helping.md Outdated Show resolved Hide resolved
@itscynxx
Copy link
Contributor Author

me when i forget to check github for 3 days

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review again. This PR is so much text that I tend to just drift off halfway through...

docs/helping.md Outdated Show resolved Hide resolved
docs/helping.md Outdated Show resolved Hide resolved
docs/helping.md Outdated Show resolved Hide resolved
docs/helping.md Outdated Show resolved Hide resolved
docs/helping.md Outdated Show resolved Hide resolved
docs/helping.md Outdated Show resolved Hide resolved
docs/helping.md Outdated Show resolved Hide resolved
@GeckoEidechse
Copy link
Member

I'm starting to think we might wanna move the log reading part into a separate PR ^^"

@itscynxx
Copy link
Contributor Author

Updated, removed the log reading section, fixed some typos, added mentions of both Discord bots to a separate bit of the guide (because I don't really want to shove it in people's faces, but it is nice to know), as well as moving the tags mention to a link to the help bot's dashboard. It just links to dashboard/<NORTHSTAR_SERVER_ID>/tags, meaning users still need to log in with permissions to view them.

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another unfinished review.

Honestly there's so much text in this that it will be an endless back and forth. It might make more sense to first do a PR that adds the structure and then PR the sections one by one slim things down.

(If we do that, please keep this PR here open though so that we can see the progress in the diff etc)

docs/helping.md Outdated Show resolved Hide resolved
docs/helping.md Outdated Show resolved Hide resolved
docs/helping.md Show resolved Hide resolved
docs/helping.md Outdated Show resolved Hide resolved
docs/helping.md Outdated Show resolved Hide resolved
docs/helping.md Outdated Show resolved Hide resolved
docs/helping.md Outdated Show resolved Hide resolved
docs/helping.md Outdated Show resolved Hide resolved
docs/helping.md Outdated Show resolved Hide resolved
docs/helping.md Outdated Show resolved Hide resolved
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I think we should condense the information on the helping page a bit more so that it doesn't feel like a full on novel.

Should be good enough for now however.

@GeckoEidechse
Copy link
Member

CI failed cause Arch wiki is down :trollface:

docs/helping.md Outdated Show resolved Hide resolved
docs/helping.md Outdated Show resolved Hide resolved
@GeckoEidechse GeckoEidechse merged commit 6cab0a5 into R2Northstar:main Dec 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants