Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanilla section update #260

Merged
merged 7 commits into from
Dec 19, 2023

Conversation

itscynxx
Copy link
Contributor

@itscynxx itscynxx commented Nov 24, 2023

I recently did one of these, however I feel like it really needed work still and was quite confusing to the average user

This version does in fact reference VanillaPlus, a mod that I work on, however I think it's for good reason. This reason being that without VanillaPlus, mods using Mod Settings will not work (as it's blacklisted due to how many errors it would've caused when it got added to Northstar), and without either downgrading Northstar or renaming the Mod Settings mod (which are both quite the task for a lot of end users), these mods will simply break the game. Additionally, previous methods would omit things such as the mods list, as that is included in Northstar.Client, which having enabled would break vanilla.

I've updated the only other source I personally found of vanilla profiles, which was in the VTOL guide

I decided to make the headers not reference VanillaPlus as to more easily update them when vanilla compatibility is included in Northstar. I do not want to "take over" vanilla sections and shill the mod I work on the most, but I feel like it's currently the best solution. I will also be helping with vanilla compatibility in Northstar as much as I can, and deprecating VanillaPlus when it's served it's purpose.

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I like the change and splitting vanilla into its own page.

Found one small grammar issue that could use a quick fix and then it's ready to merge :D

@GeckoEidechse
Copy link
Member

Changes were addressed, time to merge :D

@GeckoEidechse GeckoEidechse merged commit 06bb873 into R2Northstar:main Dec 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants