feat: Launch arguments

[Alystrasz]

This interface lists launch arguments (stolen from wiki page), and enables users to toggle them. A description of each argument can be displayed by hovering related item.

This is merely an interface with the ns_startup_args.txt file.

launch_args_selector.webm

Closes #147.

TODOs

• -language argument
• Should we let users write anything they want as launch args? (I don't think so)
• Can users set up envvars the same way as launch args?
• i18n
• Handle duplicated arguments in file
• Distinction between "official" and "custom" arguments
• Fix clippy issues
• Remove tag animations

[Alystrasz]

@GeckoEidechse maybe you'll have answers to some of my questions 😃

[GeckoEidechse]

Holy fuck this looks really cool :O

Should we let users write anything they want as launch args? (I don't think so)

I'm tending towards a yes though in that case it should then also display the raw string in a text box somewhere ^^

[GeckoEidechse]

Probably a bit too early to do a review atm but I was in the mood ^^"

In regards to clippy errors, half of them are caused by "unused function" which makes no sense to me cause clearly the function is used in the macro to set up tauri. Maybe one of the Rust wizards (cat, emerald, snagg, ...) in the Northstar Discord have an idea. For the rest feel free to poke me if you need/want any help <3

[Alystrasz]

While FlightCore UI can try preventing users from breaking their launch arguments configuration by adding random words in it, I feel like the rust backend should be responsible for its integrity.
What do you think should happen when backend detects a malformed arguments file? Overwrite it with correctly-formatted arguments? Refuse to parse it and raise an error?

[GeckoEidechse]

What do you think should happen when backend detects a malformed arguments file? Overwrite it with correctly-formatted arguments? Refuse to parse it and raise an error?

Correcting user mistake sounds very difficult to do tbh. It makes more sense IMO to just reject with error and if possible say what's wrong (though the second part of that might also be quite difficult to do ^^)

[ASpoonPlaysGames]

Honestly, there shouldn't rly be any handling of this sorta thing. It's almost impossible to know which launch args exist and are valid and stuff. Launch args are for advanced users and they should not need their hand to be held

[ASpoonPlaysGames]

To elaborate:

• Any convar (which mods can add) is a valid launch arg (with the + prefix i believe)
• Plugins can just check command line args for whatever they want, and there isn't a manifest or anything for it
• Launcher can do the same as plugins (but we can control that a bit more)

[Alystrasz]

Thanks for your feedback!
What will be the correct way to use launch arguments once associated file has been removed (R2Northstar/NorthstarLauncher#517)? Directly as executable arguments?

[F1F7Y]

Directly as executable arguments?

Exactly that

To expand on @ASpoonPlaysGames comment:

Personally i think the user should have access to the ability to set commandline arguments in a text entry ( just like steam does it). You could then add what you show off in the initial PR comment into the DEV section with useful arguments to make testing easier.

[Alystrasz]

Since we're talking removing the ns_startup_args.txt file again, I'll rework this by storing arguments in flightcore itself.

[Alystrasz]

I need help on the two following points:

• making sure launch args are correctly sent to Steam
• finding out why launch args is interpreted as a string by launcher (fixed in 2a4fc2f)