Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change repair window to tab #982

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

GeckoEidechse
Copy link
Member

The return of #72 :>

Why? After using it for a while now, I find the extra window just super clunky. Plus it doesn't play nice with devices like the SteamDeck.

The downside of having it all in one window is that I will need to add more state tracking so that the user can start a repair job, switch tab and then come back again and the information that the job is still running is not lost.

TODOs:

  • Fix CSS so that header info bar does not clip
  • Invalidate outdated translations mentioning "window" Weblate
  • Remove now unused code for opening window (might just still keep it around in case I want to re-use it for spawning other windows
  • ???

@GeckoEidechse GeckoEidechse force-pushed the feat/change-repair-window-to-tab branch from 1d125ed to 9ee553e Compare July 15, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant