Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gcp-deploy.yml #123

Closed
wants to merge 2 commits into from
Closed

Update gcp-deploy.yml #123

wants to merge 2 commits into from

Conversation

justinh-rahb
Copy link
Collaborator

Summary

This PR updates the GitHub action used for deploying a Cloud Function to include the --image-url flag followed by the URL of the GCR container image in the gcloud functions deploy command, ensuring continued use of GCR as a non-default option after January 15, 2024.

Description

Google Cloud Functions recently announced a transition from using GCR to AR as the default storage for container images. Although this change will not take effect until at least January 15, 2024, it is recommended that users explicitly set the image registry setting back to GCR if they wish to continue using it as a non-default option.

In light of this announcement, this PR modifies the GitHub action used for deploying a Cloud Function by including the --image-url flag followed by the URL of the GCR container image in the gcloud functions deploy command. This ensures that the Cloud Function will continue to use the GCR container image even after the transition to AR takes place.

Related Issue(s)

None.

Motivation and Context

This change was necessary to ensure that the Cloud Function will continue to use the GCR container image even after the transition from GCR to AR takes place. This PR updates the GitHub action used for deploying a Cloud Function by including the --image-url flag followed by the URL of the GCR container image in the gcloud functions deploy command.

Types of changes

  • New feature (non-breaking change which adds functionality)

@justinh-rahb justinh-rahb self-assigned this Jan 10, 2024
@justinh-rahb justinh-rahb marked this pull request as draft February 17, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant