Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hover-on-taskbar #52

Open
wants to merge 1 commit into
base: rebased
Choose a base branch
from

Conversation

1ananya3
Copy link

I have added hover effect on taskbar.

@RAJAGOPALAN-GANGADHARAN
Copy link
Owner

RAJAGOPALAN-GANGADHARAN commented Dec 31, 2021

@1ananya3 Thanks for the PR, few problems

  1. Applauncher on hovering gets triggered (should probably use showMiniwindow instead of assignedTask)
  2. The preview is shown on hover but doesn't stop the preview after you move the cursor out( see how windows works when you hover mouse on taskbar icons)
  3. Do we really need to use react-hover ? what about native mouseenter and exit events don't they work fine?

@1ananya3
Copy link
Author

1ananya3 commented Dec 31, 2021 via email

@1ananya3
Copy link
Author

1ananya3 commented Jan 2, 2022

I have noticed few things...
1.Whenever I use showMiniwindow instead of assignedEvent . hovering is not working.
2. mouseenter and exit is working. but for hovering mouseenter is working properly.
3. I don't need to use react-hover .
4. I have seen that the preview after I move the cursor out is not working .

@RAJAGOPALAN-GANGADHARAN
Copy link
Owner

@1ananya3 ok were you able to figure out how to rectify this?

@1ananya3
Copy link
Author

1ananya3 commented Jan 5, 2022

I have tried but I am not successful to figure it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants