Fix issue where mass capture would continue despite errors

RBech · Nov 12, 2018 · 7adafde · 7adafde
1 parent 1848898
commit 7adafde
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/app/code/community/Quickpay/Payment/Helper/Data.php b/app/code/community/Quickpay/Payment/Helper/Data.php
@@ -462,6 +462,7 @@ public function createTransaction($order, $transactionId, $type)
             $transaction->setOrderPaymentObject($order->getPayment());
             $transaction->setOrder($order);
         }
+
         if ($type == Mage_Sales_Model_Order_Payment_Transaction::TYPE_AUTH) {
             $transaction->setIsClosed(false);
         } else {

diff --git a/app/code/community/Quickpay/Payment/controllers/Adminhtml/QuickpayController.php b/app/code/community/Quickpay/Payment/controllers/Adminhtml/QuickpayController.php
@@ -24,13 +24,15 @@ public function massCaptureAction()
 
                 if (!$order->canInvoice()) {
                     $this->_getSession()->addError($this->__('Could not create invoice for %s', $order->getIncrementId()));
+                    continue;
                 }
 
                 /* @var $invoice Mage_Sales_Model_Order_Invoice */
                 $invoice = Mage::getModel('sales/service_order', $order)->prepareInvoice();
 
                 if (!$invoice->getTotalQty()) {
                     $this->_getSession()->addError($this->__('Cannot create an invoice without products for %s.', $order->getIncrementId()));
+                    continue;
                 }
 
                 $invoice->setRequestedCaptureCase(Mage_Sales_Model_Order_Invoice::CAPTURE_ONLINE);
@@ -43,6 +45,7 @@ public function massCaptureAction()
                 $transactionSave->save();
             } catch (Exception $e) {
                 $this->_getSession()->addError($this->__('Invoice and capture failed for %s: %s', $order->getIncrementId(), $e->getMessage()));
+                continue;
             }
         }